-
Notifications
You must be signed in to change notification settings - Fork 2
[ID-55] Add Firebase Auth support #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jsafoan, this is looking close! I have left a few comments below.
|
Hi @petyos, we were just talking about this. You are correct that this PR is not currently needed to support the authentication mechanisms that we are using for the ROKWIRE ecosystem. Because of this, this PR is lower priority. Since we have already done most of the work necessary, I believe we should come back to this and finish it up in case anyone wants to use it in the future. We will let you know when it is ready for your review. Thanks for checking in! |
Hi @petyos, we recently discussed supporting this functionality again, but this PR is quite out of date and will need to be restructured and abstracted appropriately. We will work on this when we get a chance and re-request your review when we are ready. Thanks! |
Resolves #55